Skip to content

Update the generated content draft URL #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2025
Merged

Conversation

marcosnav
Copy link
Contributor

@marcosnav marcosnav commented Jun 30, 2025

Intent

PR to update the provided URL when deploying content with the --draft flag, now that content drafts are included in Connect's main dashboard.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

  • Updated the URL generated when deploying using the --draft flag

Automated Tests

Updated test_deploy_draft tests that run the command with --draft, asserting the generated URL changes included in this PR.

Directions for Reviewers

Deploying with the --draft flag provides a Draft URL when the deployment succeeds:
e.g command

rsconnect deploy streamlit --server http://connect-server --api-key API_KEY --draft ./

e.g output

    Draft content URL: http://connect-server/connect/#/apps/APP_GUID/draft/BUNDLE_ID

Checklist

  • I have updated CHANGELOG.md to cover notable changes.
  • I have updated all related GitHub issues to reflect their current state.

Copy link

github-actions bot commented Jun 30, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-07-03 16:24 UTC

Copy link

github-actions bot commented Jun 30, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5143 3993 78% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/api.py 77% 🟢
TOTAL 77% 🟢

updated for commit: 403d377 by action🐍

Copy link
Contributor

@toph-allen toph-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nealrichardson nealrichardson merged commit c141e55 into main Jul 3, 2025
15 checks passed
@nealrichardson nealrichardson deleted the mnv-drafts-url-update branch July 3, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants